about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-06-20T18·00+0300
committerflokli <flokli@flokli.de>2024-06-20T21·07+0000
commit8dde022d3133d7e1be55be94821e6bb1d814f4ed (patch)
tree08376e82b795cd3a0d9cbc77e73218217f3d25a7
parent7f625e2fc104a9403c0a0eb2c6abe975948dada3 (diff)
docs(tvix): drop done TODOs in the O11Y section r/8301
OTLP shutdown behaviour was fixed in cl/11803, and tracy landed in
cl/10952 and cl/11815.

Change-Id: I310dfcc41ba62ce5b006e75a35feb839327b0e7c
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11866
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: Simon Hauser <simon.hauser@helsinki-systems.de>
Tested-by: BuildkiteCI
-rw-r--r--tvix/docs/src/TODO.md8
1 files changed, 0 insertions, 8 deletions
diff --git a/tvix/docs/src/TODO.md b/tvix/docs/src/TODO.md
index 892110a92d77..92d7c4cace81 100644
--- a/tvix/docs/src/TODO.md
+++ b/tvix/docs/src/TODO.md
@@ -233,15 +233,7 @@ logs etc, but this is something requiring a lot of designing.
  - Maybe drop `--log-level` entirely, and only use `RUST_LOG` env exclusively?
    `debug`,`trace` level across all crates is a bit useless, and `RUST_LOG` can
    be much more granular…
- - Fix OTLP sending batches on shutdown.
-   It seems for short-lived CLI invocations we don't end up receiving all spans.
-   Ensure we flush these on ctrl-c, and regular process termination.
-   See https://github.com/open-telemetry/opentelemetry-rust/issues/1395#issuecomment-2045567608
-   for some context.
-
-Later:
  - Trace propagation for HTTP clients too, using
    https://www.w3.org/TR/trace-context/ or https://www.w3.org/TR/baggage/,
    whichever makes more sense.
    Candidates: nix+http(s) protocol, object_store crates.
- - (`tracing-tracy` (cl/10952))