diff options
| author | Florian Klink <flokli@flokli.de> | 2024-06-05T20·25+0300 |
|---|---|---|
| committer | flokli <flokli@flokli.de> | 2024-06-10T16·31+0000 |
| commit | 11a6ff77067a7b9eec3f1c15412d7143cb85a047 (patch) | |
| tree | df0f732e47e710ad371ebb1e9b25694dff3d515c | |
| parent | 33e15aa950093c8930bbf509840350068dbedfd0 (diff) | |
docs(tvix/docs/TODO): document attempt to add more granular errors r/8241
Change-Id: I46f99d15a4ce9c98dcdad822d3032bda3b09c12f Reviewed-on: https://cl.tvl.fyi/c/depot/+/11754 Reviewed-by: flokli <flokli@flokli.de> Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Simon Hauser <simon.hauser@helsinki-systems.de> Tested-by: BuildkiteCI
| -rw-r--r-- | tvix/docs/src/TODO.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tvix/docs/src/TODO.md b/tvix/docs/src/TODO.md index 20ad07eb2505..66d90aaa9494 100644 --- a/tvix/docs/src/TODO.md +++ b/tvix/docs/src/TODO.md @@ -66,6 +66,14 @@ which are supposed to be skipped. This is quite primitive. We should have individual error types for BS, DS, PS. Maybe these should have some generics to still be able to carry errors from the underlying backend, similar to `IngestionError`. + There was an attempt to give PS separate error types (cl/11695), but this + ended up very verbose. + Every error had to be boxed, and a possible additional message be added. Some + errors that didn't wrap another underlying errors were hard to construct, too + (requiring the addition of errors). All of this without even having added + proper backtrace support, which would be quite helpful in store hierarchies. + `anyhow`'s `.context()` gives us most of this out of the box. Maybe we can + use that, using enums rather than `&'static str` as context in some cases? ## Fixes towards correctness - `rnix` only supports string source files, but `NixString` uses bytes (and Nix |