diff options
author | Vincent Ambo <tazjin@tvl.su> | 2024-02-26T11·18+0300 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2024-02-26T11·48+0000 |
commit | 2dbeaa80c3b79fffaa199a77a15653357f322de0 (patch) | |
tree | e3def2c11a973dbf206317e04807a5f797030a04 | |
parent | 1f3fe7d41f6655fdbe7b5f2303cf29aa059bfc2c (diff) |
fix: explicit dependencies on network-online.target r/7607
A recent change in nixpkgs introduced evaluation warnings if a systemd service is configured to start after network-online.target, but does not directly depend on it. This is done because the existing dependency from multi-user.target to network-online.target is being removed, leaving these services without an actual dependency on the service. This affected autosubmit (I added a weak dependency here, for now the service is actually on the same host as Gerrit), and sterni's mirror setup (I added a strong dependency here). Change-Id: I88a4aa69f6788c489f59533d34be3c9cea681326 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11026 Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
-rw-r--r-- | ops/modules/gerrit-autosubmit.nix | 1 | ||||
-rw-r--r-- | users/sterni/machines/ingeborg/http/code.sterni.lv.nix | 2 |
2 files changed, 3 insertions, 0 deletions
diff --git a/ops/modules/gerrit-autosubmit.nix b/ops/modules/gerrit-autosubmit.nix index 03b293ce2e9b..34342c8d55f4 100644 --- a/ops/modules/gerrit-autosubmit.nix +++ b/ops/modules/gerrit-autosubmit.nix @@ -25,6 +25,7 @@ in systemd.services.gerrit-autosubmit = { inherit description; wantedBy = [ "multi-user.target" ]; + wants = [ "network-online.target" ]; after = [ "network-online.target" ]; serviceConfig = { diff --git a/users/sterni/machines/ingeborg/http/code.sterni.lv.nix b/users/sterni/machines/ingeborg/http/code.sterni.lv.nix index 94d7915d7fe8..fd4975ed1d59 100644 --- a/users/sterni/machines/ingeborg/http/code.sterni.lv.nix +++ b/users/sterni/machines/ingeborg/http/code.sterni.lv.nix @@ -227,7 +227,9 @@ in name = unitName name; value = { description = "mirror git repository ${name}"; + requires = [ "network-online.target" ]; after = [ "network-online.target" ]; + script = let path = repoPath name repo; |