diff options
| author | Vincent Ambo <tazjin@tvl.su> | 2024-02-20T11·06+0700 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2024-02-20T11·54+0000 |
| commit | f40ff1737e829fb98a01951794eb1f3624cd3cad (patch) | |
| tree | 3355d042e8d79ae26ac4c6c5cf03d6fd593cd608 | |
| parent | 94f582341e4f37228fbdf0997255d6374264b4b3 (diff) | |
fix(tvix/eval): fix accidental recursion in printing errors r/7573
There's some code path where fancy_format_str()->Error::Display, which recurses forever and overflows the stack. This was introduced in a previous commit today. Change-Id: I87a59492099f6c138c752478901b9aa614bb57cc Reviewed-on: https://cl.tvl.fyi/c/depot/+/10990 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: Peter Kolloch <info@eigenvalue.net>
| -rw-r--r-- | tvix/eval/src/errors.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tvix/eval/src/errors.rs b/tvix/eval/src/errors.rs index 06a60fbbb904..262757021187 100644 --- a/tvix/eval/src/errors.rs +++ b/tvix/eval/src/errors.rs @@ -514,7 +514,7 @@ to a missing value in the attribute set(s) included via `with`."#, impl Display for Error { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { - write!(f, "{}", self.fancy_format_str()) + write!(f, "{}", self.kind) } } |