about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-04-14T14·06+0300
committerclbot <clbot@tvl.fyi>2024-04-15T19·33+0000
commit80d0b305a74885850aae5f5941d2c9fccbeaec9b (patch)
tree98a4abf3e7f85acfd328808fd1d08b0cf2359377
parente958cb02517dc69e4fe489a91e4b39c7d1d583ac (diff)
docs(tvix/castore/blobservice): explain open_read for small blobs more r/7938
State that this case applies if the blob is small enough to fit inside a
single chunk.

Change-Id: I0383514729e686799599b629cf1303b284147bb4
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11440
Autosubmit: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Reviewed-by: Connor Brewster <cbrewster@hey.com>
-rw-r--r--tvix/castore/src/blobservice/object_store.rs1
1 files changed, 1 insertions, 0 deletions
diff --git a/tvix/castore/src/blobservice/object_store.rs b/tvix/castore/src/blobservice/object_store.rs
index 04fb9360b427..d2d0a288a557 100644
--- a/tvix/castore/src/blobservice/object_store.rs
+++ b/tvix/castore/src/blobservice/object_store.rs
@@ -149,6 +149,7 @@ impl BlobService for ObjectStoreBlobService {
             .await
         {
             Ok(res) => {
+                // handle reading blobs that are small enough to fit inside a single chunk:
                 // fetch the entire chunk into memory, decompress, ensure the b3 digest matches,
                 // and return a io::Cursor over that data.
                 // FUTUREWORK: use zstd::bulk to prevent decompression bombs