about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-01-09T12·59+0200
committerclbot <clbot@tvl.fyi>2024-01-09T16·18+0000
commit9de1ebf23ef6b34263c5ed9704c8ee173d9d875c (patch)
tree3343a8cbf55c9b07c2cd4665f011a012ca010ffd
parent99f675ecef846ce2cbba70ac41b685f37c1a1103 (diff)
feat(tvix/castore/grpc): instrument some more functions r/7363
Change-Id: Icedb148c88c5f4a3b2242ed12df1dd8692af94fd
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10584
Autosubmit: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
-rw-r--r--tvix/castore/src/blobservice/grpc.rs2
1 files changed, 2 insertions, 0 deletions
diff --git a/tvix/castore/src/blobservice/grpc.rs b/tvix/castore/src/blobservice/grpc.rs
index 691cf8529d34..183ebb76e10c 100644
--- a/tvix/castore/src/blobservice/grpc.rs
+++ b/tvix/castore/src/blobservice/grpc.rs
@@ -49,6 +49,7 @@ impl BlobService for GRPCBlobService {
         }
     }
 
+    #[instrument(skip(self, digest), fields(blob.digest=%digest), err)]
     async fn open_read(&self, digest: &B3Digest) -> io::Result<Option<Box<dyn BlobReader>>> {
         // Get a stream of [proto::BlobChunk], or return an error if the blob
         // doesn't exist.
@@ -80,6 +81,7 @@ impl BlobService for GRPCBlobService {
 
     /// Returns a BlobWriter, that'll internally wrap each write in a
     /// [proto::BlobChunk], which is send to the gRPC server.
+    #[instrument(skip_all)]
     async fn open_write(&self) -> Box<dyn BlobWriter> {
         // set up an mpsc channel passing around Bytes.
         let (tx, rx) = tokio::sync::mpsc::channel::<bytes::Bytes>(10);