diff options
author | Ryan Lahfa <tvl@lahfa.xyz> | 2023-12-25T23·41+0100 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2024-01-03T18·14+0000 |
commit | 88fcab68d4c3fa33cb2bf14d057a3a2dcc0120d5 (patch) | |
tree | 5abf11f2a9508bd85dddf8873d333b00a7bf207e | |
parent | c7d6d0879941f285b61b4319afb720ba05ebb767 (diff) |
chore(tvix/eval): note on context-aware `toString` r/7326
Change-Id: Ie26ebd16e95e6a7b6f81051d8269169842978058 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10430 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: raitobezarius <tvl@lahfa.xyz>
-rw-r--r-- | tvix/eval/src/builtins/mod.rs | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs index 2f317dbf9d9f..22aa48668294 100644 --- a/tvix/eval/src/builtins/mod.rs +++ b/tvix/eval/src/builtins/mod.rs @@ -1131,6 +1131,8 @@ mod pure_builtins { #[builtin("toString")] async fn builtin_to_string(co: GenCo, #[lazy] x: Value) -> Result<Value, ErrorKind> { // coerce_to_string forces for us + // FIXME: should `coerce_to_string` preserve context? + // it does for now. let span = generators::request_span(&co).await; x.coerce_to_string( co, |