about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-02-14T01·58+0700
committerflokli <flokli@flokli.de>2024-02-17T08·01+0000
commit87bda3ae7aaf459cd30672164587a3fe246d209a (patch)
tree1f3888f87e4d2bd8487e85e586b6d6489ded8e4a
parent44624284fd88d676527ff3df20fae9ab78a31089 (diff)
feat(tvix/glue): tune instrumentations in TvixStoreIO r/7542
Print store paths with their ToString implementation for brevity, and
don't log the sucessful return value of read_to_string.

Change-Id: I01b6838398acd66b8818095622f361fcca26fa77
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10854
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Tested-by: BuildkiteCI
-rw-r--r--tvix/glue/src/tvix_store_io.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/tvix/glue/src/tvix_store_io.rs b/tvix/glue/src/tvix_store_io.rs
index ed06eba89686..a3e4474a66f7 100644
--- a/tvix/glue/src/tvix_store_io.rs
+++ b/tvix/glue/src/tvix_store_io.rs
@@ -74,7 +74,7 @@ impl TvixStoreIO {
     ///
     /// In case there is no PathInfo yet, this means we need to build it
     /// (which currently is stubbed out still).
-    #[instrument(skip(self), ret, err)]
+    #[instrument(skip(self, store_path), fields(store_path=%store_path), ret, err)]
     async fn store_path_to_node(
         &self,
         store_path: &StorePath,
@@ -138,7 +138,7 @@ impl EvalIO for TvixStoreIO {
         }
     }
 
-    #[instrument(skip(self), ret, err)]
+    #[instrument(skip(self), err)]
     fn read_to_string(&self, path: &Path) -> io::Result<String> {
         if let Ok((store_path, sub_path)) =
             StorePath::from_absolute_path_full(&path.to_string_lossy())