about summary refs log tree commit diff
diff options
context:
space:
mode:
authorRyan Lahfa <tvl@lahfa.xyz>2023-12-26T03·49+0100
committerclbot <clbot@tvl.fyi>2024-01-03T16·54+0000
commite15b6580cce173c7a3246d421c4d16285bd892e9 (patch)
treea07039072de5d9b2852e225c3f01debfb1429575
parent743c3620491dba67ebeaf439a4f0073f97d5e0af (diff)
chore(tvix/eval): notes on coercion and contexts r/7318
We make a case for adding a `reject_context` `CoercionKind` here.
It does happen during concatenation actually for path concats.

Change-Id: I0c196aad917550b9bcd0896cd2127a94f8181ffb
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10444
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
Autosubmit: raitobezarius <tvl@lahfa.xyz>
-rw-r--r--tvix/eval/src/vm/mod.rs3
1 files changed, 3 insertions, 0 deletions
diff --git a/tvix/eval/src/vm/mod.rs b/tvix/eval/src/vm/mod.rs
index febf1cb195ce..e366121aba76 100644
--- a/tvix/eval/src/vm/mod.rs
+++ b/tvix/eval/src/vm/mod.rs
@@ -1232,6 +1232,9 @@ async fn add_values(co: GenCo, a: Value, b: Value) -> Result<Value, ErrorKind> {
                     // contain any string context, the resulting error of such a
                     // case can not be replicated by us.
                     import_paths: false,
+                    // FIXME(raitobezarius): per https://b.tvl.fyi/issues/364, this is a usecase
+                    // for having a `reject_context: true` option here. This didn't occur yet in
+                    // nixpkgs during my evaluations, therefore, I skipped it.
                 },
             )
             .await