about summary refs log tree commit diff
diff options
context:
space:
mode:
authorRyan Lahfa <tvl@lahfa.xyz>2023-12-26T00·05+0100
committerclbot <clbot@tvl.fyi>2024-01-03T18·15+0000
commitcbd22af2b5577d588815e8b59b27c98befc57c46 (patch)
tree0104b74c4dbf420052f6975597e2945b3ca98115
parente372b1d1a54231cd93f67138771aac47c2a802d4 (diff)
chore(tvix/eval): note on context-aware `hashString` r/7329
It must propagate context too.

Change-Id: If57c22c9723ea02aa013f69d3dcf96054476d8de
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10433
Tested-by: BuildkiteCI
Autosubmit: raitobezarius <tvl@lahfa.xyz>
Reviewed-by: tazjin <tazjin@tvl.su>
-rw-r--r--tvix/eval/src/builtins/mod.rs1
1 files changed, 1 insertions, 0 deletions
diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs
index 89ab5edb1bc9..fa84afb70af6 100644
--- a/tvix/eval/src/builtins/mod.rs
+++ b/tvix/eval/src/builtins/mod.rs
@@ -588,6 +588,7 @@ mod pure_builtins {
         _algo: Value,
         _string: Value,
     ) -> Result<Value, ErrorKind> {
+        // FIXME: propagate contexts here.
         Ok(Value::Catchable(CatchableErrorKind::UnimplementedFeature(
             "hashString".to_string(),
         )))