diff options
author | Florian Klink <flokli@flokli.de> | 2023-03-27T16·12+0200 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2023-04-07T09·35+0000 |
commit | 60751b70ebcfcac031ba77234338c460cd3416e6 (patch) | |
tree | caf68331360715c4c6a464fa973df96926b52cf3 | |
parent | 0cb2057a76d74bc7ac342202d80f1be63474d86f (diff) |
docs(tvix/store/grpc_directorysvc_wrapper): add TODO r/6076
The logic validating connectivity of Directory nodes should be moved to SimplePutter, and this use whatever DirectoryPutter the store comes with. Change-Id: Id68a86a96cc49ff73920017839788859ea9c5161 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8358 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
-rw-r--r-- | tvix/store/src/proto/grpc_directoryservice_wrapper.rs | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tvix/store/src/proto/grpc_directoryservice_wrapper.rs b/tvix/store/src/proto/grpc_directoryservice_wrapper.rs index 06df07a108fb..73036229208c 100644 --- a/tvix/store/src/proto/grpc_directoryservice_wrapper.rs +++ b/tvix/store/src/proto/grpc_directoryservice_wrapper.rs @@ -91,6 +91,9 @@ impl<DS: DirectoryService + Send + Sync + Clone + 'static> request: Request<Streaming<proto::Directory>>, ) -> Result<Response<proto::PutDirectoryResponse>, Status> { let mut req_inner = request.into_inner(); + // TODO: let this use DirectoryPutter to the store it's connected to, + // and move the validation logic into [SimplePutter]. + // This keeps track of the seen directory keys, and their size. // This is used to validate the size field of a reference to a previously sent directory. // We don't need to keep the contents around, they're stored in the DB. |