diff options
| author | Vincent Ambo <mail@tazj.in> | 2020-07-01T00·16+0100 |
|---|---|---|
| committer | tazjin <mail@tazj.in> | 2020-07-01T16·51+0000 |
| commit | 03076c3977bad32c017810e13adb428411be63cd (patch) | |
| tree | a25e53af19687e1c8d7489a9942edec4f414e50d | |
| parent | c0f07e142eb45fe847f657eacbb4d05fcb64382b (diff) | |
fix(besadii): Do not pass on update values for meta refs r/1144
Before this change, besadii would skip further processing of meta refs (which happen for every CL metadata change), but it would still schedule a build by returning an update - which would then inevitably fail. This change makes besadii skip meta refs the same way it skips non-depot builds, i.e. completely. Move *on* from meta refs, do *not* collect $100. Change-Id: I269d2299f4d3cb1f9c041da8c92fa00ae7794b38 Reviewed-on: https://cl.tvl.fyi/c/depot/+/825 Reviewed-by: eta <eta@theta.eu.org> Reviewed-by: BuildkiteCI Tested-by: BuildkiteCI
| -rw-r--r-- | ops/besadii/main.go2 | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ops/besadii/main.go2 b/ops/besadii/main.go2 index 8fada435ee57..dac711ce28b1 100644 --- a/ops/besadii/main.go2 +++ b/ops/besadii/main.go2 @@ -154,12 +154,12 @@ func refUpdatedFromFlags() (*refUpdated, error) { return nil, fmt.Errorf("'ref-updated' hook invoked without required arguments") } - if update.project != "depot" { + if update.project != "depot" || metaRegexp.MatchString(update.ref) { // this is not an error, but also not something we handle. return nil, nil } - if branchRegexp.MatchString(update.ref) || metaRegexp.MatchString(update.ref) { + if branchRegexp.MatchString(update.ref) { // these refs don't need special handling, just move on return &update, nil } |