about summary refs log tree commit diff
diff options
context:
space:
mode:
authorLoo Rong Jie <loorongjie@gmail.com>2018-10-09T15·36+0800
committerLoo Rong Jie <loorongjie@gmail.com>2018-10-09T15·36+0800
commita76ceed6f68efc9efa64b7a849e9ec7e670030b2 (patch)
treeaf2996d89a0261148ccafeeff35668e4d1ca4eff
parent6b16ba047a6a7ee44380fc39b50ab135fecf09c7 (diff)
Add comment and todo
-rw-r--r--CMake/AbseilHelpers.cmake2
1 files changed, 2 insertions, 0 deletions
diff --git a/CMake/AbseilHelpers.cmake b/CMake/AbseilHelpers.cmake
index e73a2ab3aa30..41d66d7ec538 100644
--- a/CMake/AbseilHelpers.cmake
+++ b/CMake/AbseilHelpers.cmake
@@ -137,6 +137,7 @@ function(absl_cc_library)
       add_library(${_NAME} STATIC ${ABSL_CC_LIB_SRCS} ${ABSL_CC_LIB_HDRS})
       target_include_directories(${_NAME}
         PUBLIC ${ABSL_COMMON_INCLUDE_DIRS})
+      # TODO(rongjiecomputer): Revisit ABSL_COMPILE_CXXFLAGS when fixing GH#123
       target_compile_options(${_NAME}
         PRIVATE ${ABSL_COMPILE_CXXFLAGS} ${ABSL_CC_LIB_COPTS})
       target_link_libraries(${_NAME}
@@ -148,6 +149,7 @@ function(absl_cc_library)
       # Add all Abseil targets to a a folder in the IDE for organization.
       set_property(TARGET ${_NAME} PROPERTY FOLDER ${ABSL_IDE_FOLDER})
     else()
+      # Generating header-only library
       add_library(${_NAME} INTERFACE)
       target_include_directories(${_NAME} INTERFACE ${ABSL_COMMON_INCLUDE_DIRS})
       target_link_libraries(${_NAME}