about summary refs log tree commit diff
diff options
context:
space:
mode:
authorGriffin Smith <grfn@gws.fyi>2021-05-23T12·11+0200
committergrfn <grfn@gws.fyi>2021-05-23T14·16+0000
commitba6bee80fb90a80c41118991ca754a4ba5b73440 (patch)
tree8c84497a0f686c1ba915873a53c2e6430938684d
parent797212077d197d8e8dbc2377902bb1b4b129ee5b (diff)
fix(panettone): Fix handling of issue-not-found r/2613
The accessor function to get the ID of the `model:issue-not-found`
condition is `not-found-id`, not `id`! Also, add a missing space to the
title.

Fixes: b/127
Change-Id: I91c71feaf1fe877e6a14453a9e75cf27d56fee31
Reviewed-on: https://cl.tvl.fyi/c/depot/+/3140
Reviewed-by: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
-rw-r--r--web/panettone/src/packages.lisp2
-rw-r--r--web/panettone/src/panettone.lisp4
2 files changed, 3 insertions, 3 deletions
diff --git a/web/panettone/src/packages.lisp b/web/panettone/src/packages.lisp
index 3e6aa4a05f4f..b0833e454135 100644
--- a/web/panettone/src/packages.lisp
+++ b/web/panettone/src/packages.lisp
@@ -43,7 +43,7 @@
    :field :previous-value :new-value
 
    :get-issue :issue-exists-p :list-issues :create-issue :set-issue-status
-   :update-issue :delete-issue :issue-not-found
+   :update-issue :delete-issue :issue-not-found :not-found-id
 
    :issue-events
 
diff --git a/web/panettone/src/panettone.lisp b/web/panettone/src/panettone.lisp
index 3d803e1fb6a9..0b1af742c838 100644
--- a/web/panettone/src/panettone.lisp
+++ b/web/panettone/src/panettone.lisp
@@ -396,7 +396,7 @@
 
 (defun render/not-found (entity-type)
   (render ()
-    (:h1 (who:esc entity-type) "Not Found")))
+    (:h1 (who:esc entity-type) " Not Found")))
 
 ;;;
 ;;; HTTP handlers
@@ -446,7 +446,7 @@ given subject an body (in a thread, to avoid blocking)"
   (handler-case (funcall next)
     (model:issue-not-found (err)
       (render/not-found
-       (format nil "Issue #~A" (model:id err))))))
+       (format nil "Issue #~A" (model:not-found-id err))))))
 
 (defroute login-form ("/login" :method :get)
     (original-uri)