diff options
| author | Florian Klink <flokli@flokli.de> | 2022-11-19T21·14+0000 |
|---|---|---|
| committer | flokli <flokli@flokli.de> | 2022-12-27T13·27+0000 |
| commit | a2ac8a66c1bf151a9d70704b23ec2bd2dd3b99a6 (patch) | |
| tree | e5acc31fa9a7f0920f2dda535edf30e6b3ffd095 | |
| parent | d0799a7aa489cd6c3340ab347302fed86fe978f3 (diff) | |
feat(nix/bufCheck): ensure .pb.go is up to date r/5500
Change-Id: I03e1c3aced266966f6959dbce05c1f1fb1480b5a Reviewed-on: https://cl.tvl.fyi/c/depot/+/7323 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
| -rw-r--r-- | buf.gen.yaml | 7 | ||||
| -rw-r--r-- | nix/bufCheck/default.nix | 17 |
2 files changed, 22 insertions, 2 deletions
diff --git a/buf.gen.yaml b/buf.gen.yaml index c126332f3080..4ed18be22e62 100644 --- a/buf.gen.yaml +++ b/buf.gen.yaml @@ -1 +1,8 @@ version: v1 +plugins: + - name: go + out: . + opt: paths=source_relative + - name: go-grpc + out: . + opt: paths=source_relative \ No newline at end of file diff --git a/nix/bufCheck/default.nix b/nix/bufCheck/default.nix index 25a8865d8dcf..97b4124d4569 100644 --- a/nix/bufCheck/default.nix +++ b/nix/bufCheck/default.nix @@ -3,7 +3,20 @@ { depot, pkgs, ... }: pkgs.writeShellScriptBin "ci-buf-check" '' - ${depot.third_party.nixpkgs.buf}/bin/buf lint . + export PATH="$PATH:${pkgs.lib.makeBinPath [ pkgs.buf pkgs.protoc-gen-go pkgs.protoc-gen-go-grpc ]}" + buf lint . + + # Run buf generate, and bail out if generated files are changed. + buf generate --path tvix/store/protos + # Check if any files have changed + if [[ -n "$(git status --porcelain -unormal)" ]]; then + echo "-----------------------------" + echo ".pb.go files need to be updated" + echo "-----------------------------" + git status -unormal + exit 1 + fi + # Report-only - ${depot.third_party.nixpkgs.buf}/bin/buf breaking . --against "./.git#ref=HEAD~1" || true + buf breaking . --against "./.git#ref=HEAD~1" || true '' |