about summary refs log tree commit diff
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2022-12-06T13·02+0300
committertazjin <tazjin@tvl.su>2022-12-15T17·26+0000
commit0fd956f2488899e3ef41065cc6e1e535cf962125 (patch)
tree9e54e6d5be59de468e5638ed76cf5f47c56f28b7
parent43eb972f7fe49a0773e1e94b1263376b2f6b7de7 (diff)
fix(tvix): remove disruptive .envrc file r/5418
This .envrc file causes additional software to be loaded, but there is
no way to opt-out even if the software is not desired:

1. If I opt-in (i.e. `direnv allow`) the file, additional stuff that I
   don't need is injected into my environment in a blocking way.

2. If I opt-out, *all* of the depot configuration (including `mg`) is
   unloaded, as direnv configurations do not trivially nest.

I have to work around this constantly by making the file contain just
the line `source_up` and then setting `--assume-unchanged` on the git
index to avoid accidentally committing the file changes.

This is kind of silly, the people who *want* this stuff to be loaded
should devise a mechanism that loads it automatically but is opt-in.

This could be done e.g. by gating something on environment variables,
or having a shell hook, or whatever. Breaking expectations that hold
elsewhere in depot is not okay, however.

If you manually want a shell for a project, run `mg shell` either with
a target specification for that project (e.g. `mg shell //tvix/store`)
or in the project's folder.

You can also just use standard nix-shell invocations.

Change-Id: I0de43378424d0cb1e1279c72c47940fecf497bf0
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7531
Reviewed-by: tazjin <tazjin@tvl.su>
Reviewed-by: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
Autosubmit: tazjin <tazjin@tvl.su>
-rw-r--r--tvix/.envrc7
1 files changed, 0 insertions, 7 deletions
diff --git a/tvix/.envrc b/tvix/.envrc
deleted file mode 100644
index 777b522575a7..000000000000
--- a/tvix/.envrc
+++ /dev/null
@@ -1,7 +0,0 @@
-if command -v lorri >/dev/null; then
-  eval "$(lorri direnv)"
-else
-  use nix
-fi
-
-source_up