about summary refs log tree commit diff
diff options
context:
space:
mode:
authorsterni <sternenseemann@systemli.org>2021-12-20T10·08+0100
committerclbot <clbot@tvl.fyi>2021-12-20T12·46+0000
commitb9f510d98961241786290893afcebadf22ad5eef (patch)
tree9479dcd3a9d850abdf44ecf3b3b370af008cda06
parent6328f1c7c8df25d5596d8dc97c6ab50778dbb0a9 (diff)
fix(nix/buildLisp): don't emit a target for impl used at top level r/3328
These targets would be the same derivation, but named differently which
is noisy and causes a few, mostly subtle issues:

* Buildkite struggles with large pipelines a bit, we can save quite a
  few steps by removing these.

* Having two jobs for the same derivation sometimes causes the annoying
  situation that an agent would do nothing except waiting for a lock.

* Non-nix CI we add in the future may not be able to recognize that
  these targets are the same and do extra work unnecessarily.

Change-Id: I1103e719ade1d3859d222b713969ac34a8765cba
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4515
Autosubmit: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
-rw-r--r--nix/buildLisp/default.nix2
1 files changed, 1 insertions, 1 deletions
diff --git a/nix/buildLisp/default.nix b/nix/buildLisp/default.nix
index 1dae0efeb198..c44e84189442 100644
--- a/nix/buildLisp/default.nix
+++ b/nix/buildLisp/default.nix
@@ -143,7 +143,7 @@ let
         let
           implementation = old.implementation or defaultImplementation;
           brokenOn = old.brokenOn or [];
-          targets = lib.subtractLists brokenOn
+          targets = lib.subtractLists (brokenOn ++ [ implementation.name ])
             (builtins.attrNames impls);
         in {
           passthru = (old.passthru or {}) // {