about summary refs log tree commit diff
diff options
context:
space:
mode:
authorEelco Dolstra <eelco.dolstra@logicblox.com>2013-02-19T15·56+0100
committerEelco Dolstra <eelco.dolstra@logicblox.com>2013-02-19T15·56+0100
commitdadf7a5b46f08b59c7e15a40937a9039ef273d63 (patch)
tree4f9a285b77daccdfb71f4fb90fa81371fa699fe6
parent3e067ac11c1621f989011432f619652a9c20e6f4 (diff)
build-remote: Use the --quiet flag
‘--option verbosity 0’ doesn't actually do anything.
-rwxr-xr-xscripts/build-remote.pl.in2
-rw-r--r--src/libmain/shared.cc7
2 files changed, 3 insertions, 6 deletions
diff --git a/scripts/build-remote.pl.in b/scripts/build-remote.pl.in
index 03cd21e97c19..dddd9e959e27 100755
--- a/scripts/build-remote.pl.in
+++ b/scripts/build-remote.pl.in
@@ -259,7 +259,7 @@ close UPLOADLOCK;
 # Perform the build.
 my $buildFlags =
     "--max-silent-time $maxSilentTime --option build-timeout $buildTimeout"
-    . " --fallback --add-root $rootsDir/\$PPID.out --option verbosity 0"
+    . " --fallback --add-root $rootsDir/\$PPID.out --quiet"
     . " --option build-keep-log false";
 
 # We let the remote side kill its process group when the connection is
diff --git a/src/libmain/shared.cc b/src/libmain/shared.cc
index e869ef0379ad..4796629dc48c 100644
--- a/src/libmain/shared.cc
+++ b/src/libmain/shared.cc
@@ -168,11 +168,10 @@ static void initAndRun(int argc, char * * argv)
     remaining.clear();
 
     /* Process default options. */
-    int verbosityDelta = lvlInfo;
     for (Strings::iterator i = args.begin(); i != args.end(); ++i) {
         string arg = *i;
-        if (arg == "--verbose" || arg == "-v") verbosityDelta++;
-        else if (arg == "--quiet") verbosityDelta--;
+        if (arg == "--verbose" || arg == "-v") verbosity = (Verbosity) (verbosity + 1);
+        else if (arg == "--quiet") verbosity = verbosity > lvlError ? (Verbosity) (verbosity - 1) : lvlError;
         else if (arg == "--log-type") {
             string s = getArg(arg, i, args.end());
             setLogType(s);
@@ -219,8 +218,6 @@ static void initAndRun(int argc, char * * argv)
         else remaining.push_back(arg);
     }
 
-    verbosity = (Verbosity) (verbosityDelta < 0 ? 0 : verbosityDelta);
-
     settings.update();
 
     run(remaining);