about summary refs log tree commit diff
diff options
context:
space:
mode:
authorEelco Dolstra <e.dolstra@tudelft.nl>2011-11-16T16·25+0000
committerEelco Dolstra <e.dolstra@tudelft.nl>2011-11-16T16·25+0000
commitd7d7910ba48d898bda2db92a4f16a6179c855f7d (patch)
tree74ac78c9e7334d2ac388feb97d67c2c2213e5335
parent63ee5e4d2a46c3619c59307d7dbb08f25d32c3e8 (diff)
* Don't decompress the manifests in /nix/var/nix/manifest. This saves
  disk space, and, since they're typically only decompressed once (to
  fill the manifest cache), doesn't make things slower.

-rw-r--r--perl/lib/Nix/Manifest.pm10
-rwxr-xr-xscripts/nix-pull.in11
2 files changed, 9 insertions, 12 deletions
diff --git a/perl/lib/Nix/Manifest.pm b/perl/lib/Nix/Manifest.pm
index 21c61d284faf..9c891abb8bd9 100644
--- a/perl/lib/Nix/Manifest.pm
+++ b/perl/lib/Nix/Manifest.pm
@@ -53,8 +53,14 @@ sub addPatch {
 sub readManifest_ {
     my ($manifest, $addNAR, $addPatch) = @_;
 
-    open MANIFEST, "<$manifest"
-        or die "cannot open `$manifest': $!";
+    # Decompress the manifest if necessary.
+    if ($manifest =~ /\.bz2$/) {
+        open MANIFEST, "$Nix::Config::bzip2 -d < $manifest |"
+            or die "cannot decompress `$manifest': $!";
+    } else {
+        open MANIFEST, "<$manifest"
+            or die "cannot open `$manifest': $!";
+    }
 
     my $inside = 0;
     my $type;
diff --git a/scripts/nix-pull.in b/scripts/nix-pull.in
index f3cba0c02619..d8352b2774bb 100755
--- a/scripts/nix-pull.in
+++ b/scripts/nix-pull.in
@@ -59,16 +59,7 @@ sub processURL {
     # First see if a bzipped manifest is available.
     if (system("$Nix::Config::curl --fail --silent --head '$url'.bz2 > /dev/null") == 0) {
         print "fetching list of Nix archives at `$url.bz2'...\n";
-        my $bzipped = downloadFile "$url.bz2";
-
-        $manifest = "$tmpDir/MANIFEST";
-
-        system("$Nix::Config::bzip2 -d < $bzipped > $manifest") == 0
-            or die "cannot decompress manifest";
-
-        $manifest = (`$Nix::Config::binDir/nix-store --add $manifest`
-                     or die "cannot copy $manifest to the store");
-        chomp $manifest;
+        $manifest = downloadFile "$url.bz2";
     }
 
     # Otherwise, just get the uncompressed manifest.