about summary refs log tree commit diff
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2022-01-14T20·21+0300
committerclbot <clbot@tvl.fyi>2022-01-14T20·30+0000
commit86a205220fdc0e3789f8f42eb30e93115777a0b0 (patch)
tree5bcb3ce0f5299daa2e269241ff755e96843e6fa8
parente8bf17317e4f24434e46d6512637f5bd15e1343d (diff)
fix(gerrit-tvl): Explicitly specify patchset on check runs r/3596
Since we now group patchsets inside of Buildkite, the results are no
longer guaranteed to be for the right patchset.

There might be some metadata passed in from Gerrit that would let us
do this with the commit ID instead, but I haven't checked.

Change-Id: I5b74a17697511160fcc89d3dbef23517d974dc6f
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4890
Tested-by: BuildkiteCI
Reviewed-by: lukegb <lukegb@tvl.fyi>
Autosubmit: tazjin <tazjin@tvl.su>
-rw-r--r--ops/gerrit-tvl/static/tvl.js1
1 files changed, 1 insertions, 0 deletions
diff --git a/ops/gerrit-tvl/static/tvl.js b/ops/gerrit-tvl/static/tvl.js
index 899e01965e5a..7019624b59d4 100644
--- a/ops/gerrit-tvl/static/tvl.js
+++ b/ops/gerrit-tvl/static/tvl.js
@@ -113,6 +113,7 @@ const tvlChecksProvider = {
       for (let job of build.jobs) {
         // TODO(lukegb): add the ability to retry these
         const checkRun = {
+          patchset: parseInt(build.env.GERRIT_PATCHSET, 10),
           attempt: attempt,
           externalId: job.id,
           checkName: job.name,