diff options
| author | Eelco Dolstra <eelco.dolstra@logicblox.com> | 2012-11-09T13·43+0100 |
|---|---|---|
| committer | Eelco Dolstra <eelco.dolstra@logicblox.com> | 2012-11-09T13·43+0100 |
| commit | 91ef4d9a81827177963bcf7708af3a46217fd0e9 (patch) | |
| tree | 41f9fe1a1f843d4ddc8b2507db7d2d159b626916 | |
| parent | a9a8baaccbe1c8291d0cfd42fe3c87377b105381 (diff) | |
Remove unnecessary call to closeMostFDs()
We have close-on-exec on all FDs now, and there is no security risk in passing open FDs to substituters anyway.
| -rw-r--r-- | src/libstore/local-store.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/libstore/local-store.cc b/src/libstore/local-store.cc index b82c03f59b4d..138010f87d17 100644 --- a/src/libstore/local-store.cc +++ b/src/libstore/local-store.cc @@ -983,7 +983,6 @@ void LocalStore::startSubstituter(const Path & substituter, RunningSubstituter & throw SysError("dupping stdout"); if (dup2(errorPipe.writeSide, STDERR_FILENO) == -1) throw SysError("dupping stderr"); - closeMostFDs(set<int>()); execl(substituter.c_str(), substituter.c_str(), "--query", NULL); throw SysError(format("executing `%1%'") % substituter); } catch (std::exception & e) { |