diff options
| author | Griffin Smith <grfn@gws.fyi> | 2020-06-16T13·59-0400 |
|---|---|---|
| committer | glittershark <grfn@gws.fyi> | 2020-06-16T15·43+0000 |
| commit | 18994b9c588977375826ea09b090b97851fb1c8e (patch) | |
| tree | f84fc3cba2e74d3ebb037edbecede3041fee6abb | |
| parent | 789696862aace272550ab1fffd5d186d7b928270 (diff) | |
fix(tools/gerrit-cli): Don't wrap ssh sniffing in a subshell r/999
This was actually executing ssh, which was kinda silly - we really just want to check the return code of the `which` invocation Change-Id: I8a4b277a2be3b0c6a43d2da830cb82a32f9ee51e Reviewed-on: https://cl.tvl.fyi/c/depot/+/428 Reviewed-by: tazjin <mail@tazj.in>
| -rw-r--r-- | tools/gerrit-cli.nix | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/gerrit-cli.nix b/tools/gerrit-cli.nix index 853f59fb63aa..05c54da331f4 100644 --- a/tools/gerrit-cli.nix +++ b/tools/gerrit-cli.nix @@ -4,7 +4,7 @@ pkgs.writeShellScriptBin "gerrit" '' TVL_USERNAME=''${TVL_USERNAME:-$(whoami)} - if $(which ssh 2>/dev/null); then + if which ssh 2>/dev/null; then ssh=ssh else ssh="${pkgs.openssh}/bin/ssh" |