diff options
| author | Vincent Ambo <mail@tazj.in> | 2020-07-01T20·43+0100 |
|---|---|---|
| committer | tazjin <mail@tazj.in> | 2020-07-01T20·55+0000 |
| commit | 6cedd8354a6dd21f1e5fe094d4eb26dd3f92b49f (patch) | |
| tree | efc4c89a376f042f7b2a718868dd4836e4eac44f | |
| parent | 7dbdd2d13ee3ea405120d0743994bf7382db4b50 (diff) | |
docs(REVIEWS): Update registration instructions for password hashes r/1153
Change-Id: Idb8e5259f7b2a7105219fd3a21dc4b5774c44460 Reviewed-on: https://cl.tvl.fyi/c/depot/+/836 Reviewed-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
| -rw-r--r-- | docs/REVIEWS.md | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/docs/REVIEWS.md b/docs/REVIEWS.md index 3f0036456bee..872bf73d6d28 100644 --- a/docs/REVIEWS.md +++ b/docs/REVIEWS.md @@ -99,11 +99,19 @@ instructions: 1. Be a member of `##tvl`. 2. Clone the depot locally. 3. Create a user entry in our LDAP server in [tvl-slapd/default.nix][tvl-slapd]. - You can create your password hash by using `slappasswd`, which ships in the - `openldap` package on most distributions. - On systems with Nix systems you can use `nix-shell -p openldap` to get access - to the command. + We recommend using ARGON2 password hashes, which can be created + with the `slappasswd` tool if OpenLDAP was compiled with ARGON2 + support. + + For convenience, we provide a wrapper script for this that you can + build with `nix-build -A tools.hash-password` in a depot checkout. + Alternatively, if you have `direnv` installed, you can add the + depot to your allowlist and just run `hash-password` which should + be added to your `$PATH` by `direnv`. + + You can probably create ARGON2 hashes with other tools, but that is + your job to figure out. 4. Create a commit adding yourself (see e.g. [CL/223](https://cl.tvl.fyi/c/depot/+/223)). 5. Submit the commit via email (see below). |