about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-06-13T07·40+0300
committerclbot <clbot@tvl.fyi>2024-06-13T16·18+0000
commit7f29cab1cc9b0cc751b49d1dac7694f5841725ab (patch)
treef443ff7f846d3fc560fad957c416b7f20c9d298d
parent99c5a2e8bcb83e595d2c12bf7296338b1687f9de (diff)
fix(tvix/glue/tvix_store_io): distinguish waiting and building r/8260
We immediately reported "Building", even though then populated necessary
inputs, which looked a bit odd. Make it clear we're still waiting, and
update the spinner message once we have all inputs we were waiting for.

In the future, we might want to have separate spans for this, so the
timer gets reset, but that's something for later.

Change-Id: Ic22c9a906d0e7e7179c5ee328162401261efc224
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11799
Reviewed-by: aspen <root@gws.fyi>
Tested-by: BuildkiteCI
Autosubmit: flokli <flokli@flokli.de>
-rw-r--r--tvix/glue/src/tvix_store_io.rs4
1 files changed, 3 insertions, 1 deletions
diff --git a/tvix/glue/src/tvix_store_io.rs b/tvix/glue/src/tvix_store_io.rs
index ad9e4a8ef897..dd93b2be1b67 100644
--- a/tvix/glue/src/tvix_store_io.rs
+++ b/tvix/glue/src/tvix_store_io.rs
@@ -182,7 +182,7 @@ impl TvixStoreIO {
                         let span = Span::current();
                         span.pb_start();
                         span.pb_set_style(&tvix_tracing::PB_SPINNER_STYLE);
-                        span.pb_set_message(&format!("🔨Building {}", &store_path));
+                        span.pb_set_message(&format!("⏳Waiting for inputs {}", &store_path));
 
                         // derivation_to_build_request needs castore nodes for all inputs.
                         // Provide them, which means, here is where we recursively build
@@ -242,6 +242,8 @@ impl TvixStoreIO {
                                 .try_collect()
                                 .await?;
 
+                        span.pb_set_message(&format!("🔨Building {}", &store_path));
+
                         // TODO: check if input sources are sufficiently dealth with,
                         // I think yes, they must be imported into the store by other
                         // operations, so dealt with in the Some(…) match arm