diff options
author | Griffin Smith <grfn@gws.fyi> | 2020-11-18T14·02-0500 |
---|---|---|
committer | glittershark <grfn@gws.fyi> | 2020-11-19T00·29+0000 |
commit | 8d24a975f1d300f43485aa33e72187a016d23a49 (patch) | |
tree | 0ba114fe1fdaf70548500b5acd1d61b36f7b66d3 /.gitignore | |
parent | 20e206a3f61c74d1a2994a614fa7eec49109f995 (diff) |
fix(tvix): Use copy constructor to add strings to protos r/1886
Passing a string directly to add_paths like this causes the proto class to take ownership over the string, meaning when it is destructed it will *explicitly* free the string. When the string's actual owner (the derivation struct) then goes out of scope it'll get freed again, causing a double-free. This fixes that to instead use the copy constructor to assign to a pointer to a new path, and covers the whole to_proto method with a rapidcheck test. Fixes: b/64 Change-Id: I84235bed9104ff430a0acf686d4a96f1e2e9a897 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2106 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions