about summary refs log tree commit diff
path: root/.git-blame-ignore-revs
diff options
context:
space:
mode:
authoredef <edef@edef.eu>2024-05-25T04·24+0000
committeredef <edef@edef.eu>2024-05-25T08·42+0000
commit49750fa1e7e307a323e22f4f0d98ad2dc88d78bf (patch)
treef98c24c80097f1fdbab222985ad0d9e9566f932e /.git-blame-ignore-revs
parentc4c42c8b6c064b8b1a30632034948de07cbef305 (diff)
fix(tvix/eval): disallow empty but allocated string contexts r/8167
Both `Some(NixContext::new())` and `None` represent empty contexts,
but the former trips up `NixString::has_context`, and seems likely
to trip up other things.

We could hide the difference in the accessors, but we don't really
*want* the distinction to exist, since heap-allocating a null value
is pretty much always a mistake.

Change-Id: Ie84d26fb0d4b59e68354891ba13bde3bae40ab6e
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11712
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to '.git-blame-ignore-revs')
0 files changed, 0 insertions, 0 deletions