From 4f2c94ba8b7f9f4d85a1d7e03f4c5272d92c3361 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Wed, 24 Jan 2024 20:44:29 +0100 Subject: [PATCH 25/25] libcamera: debayer_cpu: Make the minimum size 1280x720 pipewire + firefox default to what looks like 640x480 if we export the entire supported cropping range. Hardcode 720p as minsize for now. Signed-off-by: Hans de Goede --- include/libcamera/internal/software_isp/debayer.h | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/include/libcamera/internal/software_isp/debayer.h b/include/libcamera/internal/software_isp/debayer.h index 39e6f393..4348173d 100644 --- a/include/libcamera/internal/software_isp/debayer.h +++ b/include/libcamera/internal/software_isp/debayer.h @@ -112,9 +112,16 @@ public: return {}; } - return SizeRange(Size(pattern_size.width, pattern_size.height), - Size((inputSize.width - 2 * pattern_size.width) & ~(pattern_size.width - 1), - (inputSize.height - 2 * pattern_size.height) & ~(pattern_size.height - 1)), + /* + * pipewire + firefox default to what looks like 640x480 + * if we export the entire supported cropping range. + * Hardcode 720p as minsize for now. Minsize should be + * Size(pattern_size.width, pattern_size.height) + */ + unsigned int w = (inputSize.width - 2 * pattern_size.width) & ~(pattern_size.width - 1); + unsigned int h = (inputSize.height - 2 * pattern_size.height) & ~(pattern_size.height - 1); + return SizeRange(Size(std::min(w, 1280u), std::min(h, 720u)), + Size(w, h), pattern_size.width, pattern_size.height); } -- 2.43.0