From 0d24efcdc9d00cf1e66e4308facfb94fbbf2dd3d Mon Sep 17 00:00:00 2001 From: sterni Date: Fri, 14 Jan 2022 00:03:02 +0100 Subject: fix(web/panettone): make (who:html-mode) stick (who:html-mode) needs to be set at macro expansion time to properly take effect which wasn't the case before, but is ensured now by :compile-toplevel. :load-toplevel ensures that who inside the repl will behave the same. Since the :html5 behavior is now actually used, we need to adjust some of the test cases to account for the different :html5 escaping mode. Change-Id: I4dfe1d2db38da6a2486fde86596f7e5f50ed8b9f Reviewed-on: https://cl.tvl.fyi/c/depot/+/4885 Tested-by: BuildkiteCI Reviewed-by: grfn --- web/panettone/src/panettone.lisp | 3 ++- web/panettone/test/inline-markdown_test.lisp | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'web') diff --git a/web/panettone/src/panettone.lisp b/web/panettone/src/panettone.lisp index b16171242d..4c9c7dafee 100644 --- a/web/panettone/src/panettone.lisp +++ b/web/panettone/src/panettone.lisp @@ -56,7 +56,8 @@ (defvar *title* "Panettone") -(setf (who:html-mode) :html5) +(eval-when (:compile-toplevel :load-toplevel) + (setf (who:html-mode) :html5)) (defun render/nav () (who:with-html-output (*standard-output*) diff --git a/web/panettone/test/inline-markdown_test.lisp b/web/panettone/test/inline-markdown_test.lisp index a32464456d..bb90750436 100644 --- a/web/panettone/test/inline-markdown_test.lisp +++ b/web/panettone/test/inline-markdown_test.lisp @@ -21,7 +21,7 @@ (inline-markdown-unit-test inline-markdown-html-escaping-test "âÀü" - "<tag>öäü") + "<tag>öäü") (inline-markdown-unit-test inline-markdown-nesting-test @@ -51,4 +51,4 @@ (inline-markdown-unit-test inline-markdown-unicode-safe "Does Unicode πŸ‘¨β€πŸ‘¨β€πŸ‘§β€πŸ‘¦ break \\πŸ‘©πŸΎβ€πŸ¦° tokenization?" - "Does Unicode 👨‍👨‍👧‍👦 break \\👩🏾‍🦰 tokenization?") + "Does Unicode 👨‍👨‍👧‍👦 break \\👩🏾‍🦰 tokenization?") -- cgit 1.4.1