From e1067b1497b3dea0c37ae51bba21f42f1e7d35b5 Mon Sep 17 00:00:00 2001 From: glittershark Date: Wed, 18 Nov 2020 14:08:30 +0000 Subject: revert(panettone): announce newly created issues using irccat This reverts commit 2e2bdf9c6ce1cd66ba5cfe1a42786a6f486b7969. Reason for revert: this is not working, and is resulting in newly created issues just showing a blank page (b/74) Change-Id: I3f06afc52d6c5289269402fc75bb32ad9c376bf4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2082 Tested-by: BuildkiteCI Reviewed-by: tazjin --- web/panettone/default.nix | 1 - web/panettone/src/irc.lisp | 24 ------------------------ web/panettone/src/packages.lisp | 5 ----- web/panettone/src/panettone.lisp | 12 ++++-------- 4 files changed, 4 insertions(+), 38 deletions(-) delete mode 100644 web/panettone/src/irc.lisp (limited to 'web/panettone') diff --git a/web/panettone/default.nix b/web/panettone/default.nix index 8d112901ec..3ff8ca55ec 100644 --- a/web/panettone/default.nix +++ b/web/panettone/default.nix @@ -26,7 +26,6 @@ depot.nix.buildLisp.program { ./src/css.lisp ./src/authentication.lisp ./src/model.lisp - ./src/irc.lisp ./src/panettone.lisp ]; diff --git a/web/panettone/src/irc.lisp b/web/panettone/src/irc.lisp deleted file mode 100644 index a54112811f..0000000000 --- a/web/panettone/src/irc.lisp +++ /dev/null @@ -1,24 +0,0 @@ -;;;; Using irccat to send IRC notifications - -(in-package :panettone.irc) - -(defun get-irccat-config () - "Reads the IRCCATHOST and IRCCATPORT environment variables, and returns them as two values if they both exist (otherwise, returns NIL)." - (destructuring-bind (host port) - (mapcar #'uiop:getenvp '("IRCCATHOST" "IRCCATPORT")) - (when (and host port) - (values host (parse-integer port))))) - -(defun send-irc-notification (body &key channel) - "Sends BODY to the IRC channel CHANNEL (starting with #), if an IRCCat server is configured (using the IRCCATHOST and IRCCATPORT environment variables) -If CHANNEL is NIL, sends the BODY to the first channel configured in the IRCCat configuration. -May signal a condition if sending fails." - (multiple-value-bind (irchost ircport) - (get-irccat-config) - (when irchost - (let ((socket (socket-connect irchost ircport))) - (unwind-protect - (progn - (format (socket-stream socket) "~@[~A ~]~A~%" channel body) - (finish-output (socket-stream socket))) - (ignore-errors (socket-close socket))))))) diff --git a/web/panettone/src/packages.lisp b/web/panettone/src/packages.lisp index 87285fa34d..1a8453055f 100644 --- a/web/panettone/src/packages.lisp +++ b/web/panettone/src/packages.lisp @@ -7,10 +7,6 @@ (:use :cl :lass) (:export :styles)) -(defpackage panettone.irc - (:use :cl :usocket) - (:export :send-irc-notification)) - (defpackage :panettone.authentication (:nicknames :authn) (:use :cl :panettone.util :klatre) @@ -51,6 +47,5 @@ :id :subject :body :author-dn :issue-id :status :created-at :field :previous-value :new-value :acting-user-dn :issue-comments :num-comments :issue-events) - (:import-from :panettone.irc :send-irc-notification) (:shadow :next) (:export :start-pannetone :config :main)) diff --git a/web/panettone/src/panettone.lisp b/web/panettone/src/panettone.lisp index 9135bcf8dd..cef3572214 100644 --- a/web/panettone/src/panettone.lisp +++ b/web/panettone/src/panettone.lisp @@ -450,14 +450,10 @@ (render/issue-form (make-instance 'model:issue :subject subject :body body) "Subject is required") - (let ((issue - (model:create-issue :subject subject - :body body - :author-dn (dn *user*)))) - (send-irc-notification (format nil "b/~A: \"~A\" opened by ~A - https://b.tvl.fyi/issues/~A" - (issue-id issue) subject (dn *user*) - (issue-id issue)) - :channel (uiop:getenvp "ISSUECHANNEL")) + (progn + (model:create-issue :subject subject + :body body + :author-dn (dn *user*)) (hunchentoot:redirect "/")))) (defroute show-issue -- cgit 1.4.1