From cc802eb44ba831cb6e0330196c7f59aaa3e49c94 Mon Sep 17 00:00:00 2001 From: William Carroll Date: Fri, 5 Aug 2022 13:33:28 -0700 Subject: fix(wpcarro/emacs): Remove lingering dash.el dep CI couldn't catch this because the dependency is discovered at runtime, and there were no tests consuming `list-concat`. Added the tests and removed the usage of `-concat`. Change-Id: I5bcce9aa8170001a9d35c104da09374ab30ffbc5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6043 Reviewed-by: wpcarro Autosubmit: wpcarro Tested-by: BuildkiteCI --- users/wpcarro/emacs/pkgs/list/list.el | 2 +- users/wpcarro/emacs/pkgs/list/tests.el | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) (limited to 'users') diff --git a/users/wpcarro/emacs/pkgs/list/list.el b/users/wpcarro/emacs/pkgs/list/list.el index 3196d85856..6747257d98 100644 --- a/users/wpcarro/emacs/pkgs/list/list.el +++ b/users/wpcarro/emacs/pkgs/list/list.el @@ -44,7 +44,7 @@ (defun list-concat (&rest lists) "Joins `LISTS' into on list." - (apply #'-concat lists)) + (apply #'append lists)) (defun list-duplicate (n x) "Duplicates the given element, X, N times in a list." diff --git a/users/wpcarro/emacs/pkgs/list/tests.el b/users/wpcarro/emacs/pkgs/list/tests.el index 4ee03c6b97..4b45796883 100644 --- a/users/wpcarro/emacs/pkgs/list/tests.el +++ b/users/wpcarro/emacs/pkgs/list/tests.el @@ -97,6 +97,10 @@ (should (equal '(a b c) (list-delete 'b '(a b b c)))) (should (equal '() (list-delete 'b '())))) +(ert-deftest list-concat () + (should (equal '(1 2 3 4 5) (list-concat '(1) '(2 3) '(4 5)))) + (should (equal '(1 2 3) (list-concat '() '(1 2 3))))) + ;; TODO(wpcarro): Supoprt this. ;; (ert-deftest list-zip () ;; (should (equal '((1 3 5) (2 4 6)) (list-zip '(1 2) '(3 4) '(5 6)))) -- cgit 1.4.1