From 4162186a1963b0dcf3dc47946a1cd8ad81467ac4 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Fri, 5 Mar 2021 22:35:02 +0200 Subject: feat(tazjin/rlox): Implement global variable access This also includes a fix for an issue where the identifiers of variables were pushed onto the stack, which is incorrect. Change-Id: Id89b388268efad295f29978d767aa4b33c4ded14 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2594 Reviewed-by: tazjin Tested-by: BuildkiteCI --- users/tazjin/rlox/src/bytecode/opcode.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'users/tazjin/rlox/src/bytecode/opcode.rs') diff --git a/users/tazjin/rlox/src/bytecode/opcode.rs b/users/tazjin/rlox/src/bytecode/opcode.rs index 25ce03c3c182..1c23449e76b3 100644 --- a/users/tazjin/rlox/src/bytecode/opcode.rs +++ b/users/tazjin/rlox/src/bytecode/opcode.rs @@ -30,6 +30,7 @@ pub enum OpCode { OpPrint, OpPop, - // Variable definitions + // Variable management OpDefineGlobal(usize), + OpGetGlobal(usize), } -- cgit 1.4.1