From 7437a181888f3e8938a943ae22962f21b1c03b1e Mon Sep 17 00:00:00 2001 From: Griffin Smith Date: Sun, 20 Jun 2021 16:44:12 -0400 Subject: fix(xanthous): Only use alphabetic chars for menu items Previously, we were using `smallestNotIn` for selecting new characters for menu items with duplicate chatacters - this uses the 'Bounded' instance for the type, which for Char meant the first character we would always select was \NUL - making it look like the menu item had no character, and making it impossible to actually select the menu item. This introduces an AlphaChar newtype, which is a wrapper around Char whose Bounded and Enum instances only use alphabetic characters (a-ZA-Z) and uses that for menu characters instead. Change-Id: If34ed9e9ce84f2bcb1cb87432cc6273f40b69f72 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3229 Reviewed-by: grfn Tested-by: BuildkiteCI --- users/grfn/xanthous/xanthous.cabal | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'users/grfn/xanthous/xanthous.cabal') diff --git a/users/grfn/xanthous/xanthous.cabal b/users/grfn/xanthous/xanthous.cabal index baa09fab3e36..45f85616b6d7 100644 --- a/users/grfn/xanthous/xanthous.cabal +++ b/users/grfn/xanthous/xanthous.cabal @@ -4,7 +4,7 @@ cabal-version: 1.12 -- -- see: https://github.com/sol/hpack -- --- hash: fdfa821ad291b11a2d7a7ee9cc38d7980a9b1f494b77216b141d3424168d621d +-- hash: 761fd1d1a9f9f9fdf8e14e56922558f7968401c879dcb95ca697dab03d1e9eec name: xanthous version: 0.1.0.0 @@ -359,6 +359,7 @@ test-suite test Xanthous.DataSpec Xanthous.Entities.CharacterSpec Xanthous.Entities.RawsSpec + Xanthous.Game.PromptSpec Xanthous.Game.StateSpec Xanthous.GameSpec Xanthous.Generators.Level.UtilSpec -- cgit 1.4.1