From f69e83ae7b2840d0c0d9633348beeb88605a56f0 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Tue, 13 Sep 2022 16:19:17 +0300 Subject: refactor(tvix/eval): cover all Value variants in force_for_output Avoids accidentally dropping one on the floor if we add more, pointed out by sterni in cl/6372 Change-Id: Ib7bb0ce9c8331c8337003d20c4d5240dfae1c32a Reviewed-on: https://cl.tvl.fyi/c/depot/+/6570 Reviewed-by: sterni Tested-by: BuildkiteCI --- tvix/eval/src/vm.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'tvix') diff --git a/tvix/eval/src/vm.rs b/tvix/eval/src/vm.rs index ca024c9d65..d886bf24b9 100644 --- a/tvix/eval/src/vm.rs +++ b/tvix/eval/src/vm.rs @@ -715,7 +715,14 @@ impl<'o> VM<'o> { panic!("tvix bug: internal value left on stack: {:?}", value) } - _ => Ok(()), + Value::Null + | Value::Bool(_) + | Value::Integer(_) + | Value::Float(_) + | Value::String(_) + | Value::Path(_) + | Value::Closure(_) + | Value::Builtin(_) => Ok(()), } } -- cgit 1.4.1