From 88fcab68d4c3fa33cb2bf14d057a3a2dcc0120d5 Mon Sep 17 00:00:00 2001 From: Ryan Lahfa Date: Tue, 26 Dec 2023 00:41:31 +0100 Subject: chore(tvix/eval): note on context-aware `toString` Change-Id: Ie26ebd16e95e6a7b6f81051d8269169842978058 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10430 Tested-by: BuildkiteCI Reviewed-by: tazjin Autosubmit: raitobezarius --- tvix/eval/src/builtins/mod.rs | 2 ++ 1 file changed, 2 insertions(+) (limited to 'tvix') diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs index 2f317dbf9d9f..22aa48668294 100644 --- a/tvix/eval/src/builtins/mod.rs +++ b/tvix/eval/src/builtins/mod.rs @@ -1131,6 +1131,8 @@ mod pure_builtins { #[builtin("toString")] async fn builtin_to_string(co: GenCo, #[lazy] x: Value) -> Result { // coerce_to_string forces for us + // FIXME: should `coerce_to_string` preserve context? + // it does for now. let span = generators::request_span(&co).await; x.coerce_to_string( co, -- cgit 1.4.1