From 0fd956f2488899e3ef41065cc6e1e535cf962125 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Tue, 6 Dec 2022 16:02:53 +0300 Subject: fix(tvix): remove disruptive .envrc file This .envrc file causes additional software to be loaded, but there is no way to opt-out even if the software is not desired: 1. If I opt-in (i.e. `direnv allow`) the file, additional stuff that I don't need is injected into my environment in a blocking way. 2. If I opt-out, *all* of the depot configuration (including `mg`) is unloaded, as direnv configurations do not trivially nest. I have to work around this constantly by making the file contain just the line `source_up` and then setting `--assume-unchanged` on the git index to avoid accidentally committing the file changes. This is kind of silly, the people who *want* this stuff to be loaded should devise a mechanism that loads it automatically but is opt-in. This could be done e.g. by gating something on environment variables, or having a shell hook, or whatever. Breaking expectations that hold elsewhere in depot is not okay, however. If you manually want a shell for a project, run `mg shell` either with a target specification for that project (e.g. `mg shell //tvix/store`) or in the project's folder. You can also just use standard nix-shell invocations. Change-Id: I0de43378424d0cb1e1279c72c47940fecf497bf0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7531 Reviewed-by: tazjin Reviewed-by: sterni Tested-by: BuildkiteCI Autosubmit: tazjin --- tvix/.envrc | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 tvix/.envrc (limited to 'tvix') diff --git a/tvix/.envrc b/tvix/.envrc deleted file mode 100644 index 777b522575..0000000000 --- a/tvix/.envrc +++ /dev/null @@ -1,7 +0,0 @@ -if command -v lorri >/dev/null; then - eval "$(lorri direnv)" -else - use nix -fi - -source_up -- cgit 1.4.1