From 031ca653a34bd0ca7c3c3714239459d4069e6464 Mon Sep 17 00:00:00 2001 From: William Carroll Date: Mon, 5 Sep 2022 22:17:04 -0700 Subject: feat(tvix/eval): Support builtins.bitOr Bitwise `or` on integers. Change-Id: I45b0897331d1a9b6840f9d0feedcf10acc67fcec Reviewed-on: https://cl.tvl.fyi/c/depot/+/6549 Autosubmit: wpcarro Reviewed-by: wpcarro Reviewed-by: tazjin Tested-by: BuildkiteCI --- tvix/eval/src/builtins/mod.rs | 7 +++++++ tvix/eval/src/tests/tvix_tests/eval-okay-builtins-bitor.exp | 1 + tvix/eval/src/tests/tvix_tests/eval-okay-builtins-bitor.nix | 10 ++++++++++ 3 files changed, 18 insertions(+) create mode 100644 tvix/eval/src/tests/tvix_tests/eval-okay-builtins-bitor.exp create mode 100644 tvix/eval/src/tests/tvix_tests/eval-okay-builtins-bitor.nix (limited to 'tvix') diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs index 009758fe0f..ebbc5e336c 100644 --- a/tvix/eval/src/builtins/mod.rs +++ b/tvix/eval/src/builtins/mod.rs @@ -108,6 +108,13 @@ fn pure_builtins() -> Vec { }) }) }), + Builtin::new("bitOr", 2, |args, vm| { + force!(vm, &args[0], x, { + force!(vm, &args[1], y, { + Ok(Value::Integer(x.as_int()? | y.as_int()?)) + }) + }) + }), Builtin::new("catAttrs", 2, |mut args, _| { let list = args.pop().unwrap().to_list()?; let key = args.pop().unwrap().to_str()?; diff --git a/tvix/eval/src/tests/tvix_tests/eval-okay-builtins-bitor.exp b/tvix/eval/src/tests/tvix_tests/eval-okay-builtins-bitor.exp new file mode 100644 index 0000000000..2556b4183c --- /dev/null +++ b/tvix/eval/src/tests/tvix_tests/eval-okay-builtins-bitor.exp @@ -0,0 +1 @@ +[ 0 1 1 1 8 8 8 8 ] diff --git a/tvix/eval/src/tests/tvix_tests/eval-okay-builtins-bitor.nix b/tvix/eval/src/tests/tvix_tests/eval-okay-builtins-bitor.nix new file mode 100644 index 0000000000..9c28f6d7ac --- /dev/null +++ b/tvix/eval/src/tests/tvix_tests/eval-okay-builtins-bitor.nix @@ -0,0 +1,10 @@ +[ + (builtins.bitOr 0 0) + (builtins.bitOr 1 0) + (builtins.bitOr 0 1) + (builtins.bitOr 1 1) + (builtins.bitOr 8 8) + (builtins.bitOr 8 (builtins.add 4 4)) + (builtins.bitOr (builtins.add 4 4) 8) + (builtins.bitOr (builtins.add 4 4) (builtins.add 4 4)) +] -- cgit 1.4.1