From d0a836b0e1ee1034144d1e5b71df6ab285c8450e Mon Sep 17 00:00:00 2001 From: Griffin Smith Date: Sun, 23 Oct 2022 13:37:11 -0400 Subject: feat(tvix/eval): Implement comparison for lists Lists are compared lexicographically in C++ nix as of [0], and our updated nix test suites depend on this. This implements comparison of list values in `Value::nix_cmp` using a very similar algorithm to what C++ does - similarly to there, this requires passing in the VM so we can force thunks in the list elements as we go. [0]: https://github.com/NixOS/nix/commit/09471d2680292af48b2788108de56a8da755d661# Change-Id: I5d8bb07f90647a1fec83f775243e21af856afbb1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7070 Autosubmit: grfn Reviewed-by: sterni Tested-by: BuildkiteCI --- tvix/verify-lang-tests/default.nix | 1 + 1 file changed, 1 insertion(+) (limited to 'tvix/verify-lang-tests/default.nix') diff --git a/tvix/verify-lang-tests/default.nix b/tvix/verify-lang-tests/default.nix index e05ef17a85bf..ca7ea4b348a2 100644 --- a/tvix/verify-lang-tests/default.nix +++ b/tvix/verify-lang-tests/default.nix @@ -53,6 +53,7 @@ let "eval-okay-zipAttrsWith.nix" = [ nix ]; # Comparable lists are not in Nix 2.3 "eval-okay-sort.nix" = [ nix ]; + "eval-okay-compare-lists.nix" = [ nix ]; # getAttrPos gains support for functionArgs-returned sets after 2.3 "eval-okay-getattrpos-functionargs.nix" = [ nix ]; }; -- cgit 1.4.1