From 597a6b6205c3455ac92d816ad5e85af9615f6063 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sun, 31 Dec 2023 23:33:41 +0200 Subject: refactor(tvix/castore/tests): let gen_*_service return Boxes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Only convert to and reuse an Arc<…> where needed. Change-Id: I2c1bc69cca5a4a3ebd3bdb33d6e28e1f5fb86cb9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10514 Tested-by: BuildkiteCI Autosubmit: flokli Reviewed-by: raitobezarius --- tvix/store/src/nar/import.rs | 15 ++++++---- tvix/store/src/pathinfoservice/from_addr.rs | 7 ++++- tvix/store/src/pathinfoservice/grpc.rs | 4 +-- tvix/store/src/proto/tests/grpc_pathinfoservice.rs | 4 +-- tvix/store/src/tests/nar_renderer.rs | 33 ++++++++++++++-------- 5 files changed, 41 insertions(+), 22 deletions(-) (limited to 'tvix/store') diff --git a/tvix/store/src/nar/import.rs b/tvix/store/src/nar/import.rs index 9be42aeafa..cda5b4e05a 100644 --- a/tvix/store/src/nar/import.rs +++ b/tvix/store/src/nar/import.rs @@ -220,8 +220,11 @@ where mod test { use crate::nar::read_nar; use std::io::Cursor; + use std::sync::Arc; use tokio_stream::StreamExt; + use tvix_castore::blobservice::BlobService; + use tvix_castore::directoryservice::DirectoryService; use tvix_castore::fixtures::{ DIRECTORY_COMPLICATED, DIRECTORY_WITH_KEEP, EMPTY_BLOB_DIGEST, HELLOWORLD_BLOB_CONTENTS, HELLOWORLD_BLOB_DIGEST, @@ -235,8 +238,8 @@ mod test { #[tokio::test] async fn single_symlink() { - let blob_service = gen_blob_service(); - let directory_service = gen_directory_service(); + let blob_service: Arc = gen_blob_service().into(); + let directory_service: Arc = gen_directory_service().into(); let handle = tokio::runtime::Handle::current(); @@ -263,8 +266,8 @@ mod test { #[tokio::test] async fn single_file() { - let blob_service = gen_blob_service(); - let directory_service = gen_directory_service(); + let blob_service: Arc = gen_blob_service().into(); + let directory_service: Arc = gen_directory_service().into(); let handle = tokio::runtime::Handle::current(); @@ -299,8 +302,8 @@ mod test { #[tokio::test] async fn complicated() { - let blob_service = gen_blob_service(); - let directory_service = gen_directory_service(); + let blob_service: Arc = gen_blob_service().into(); + let directory_service: Arc = gen_directory_service().into(); let handle = tokio::runtime::Handle::current(); diff --git a/tvix/store/src/pathinfoservice/from_addr.rs b/tvix/store/src/pathinfoservice/from_addr.rs index 922cd33515..73bb61bf2c 100644 --- a/tvix/store/src/pathinfoservice/from_addr.rs +++ b/tvix/store/src/pathinfoservice/from_addr.rs @@ -170,7 +170,12 @@ mod tests { #[test_case("grpc+http://localhost/some-path", false; "grpc valid invalid host and path")] #[tokio::test] async fn test_from_addr_tokio(uri_str: &str, is_ok: bool) { - let resp = from_addr(uri_str, gen_blob_service(), gen_directory_service()).await; + let resp = from_addr( + uri_str, + gen_blob_service().into(), + gen_directory_service().into(), + ) + .await; assert_eq!(resp.is_ok(), is_ok); } diff --git a/tvix/store/src/pathinfoservice/grpc.rs b/tvix/store/src/pathinfoservice/grpc.rs index 9a8599bce2..f05fe2c04d 100644 --- a/tvix/store/src/pathinfoservice/grpc.rs +++ b/tvix/store/src/pathinfoservice/grpc.rs @@ -151,8 +151,8 @@ mod tests { let router = server.add_service( crate::proto::path_info_service_server::PathInfoServiceServer::new( GRPCPathInfoServiceWrapper::new(Box::new(MemoryPathInfoService::new( - gen_blob_service(), - gen_directory_service(), + gen_blob_service().into(), + gen_directory_service().into(), )) as Box), ), diff --git a/tvix/store/src/proto/tests/grpc_pathinfoservice.rs b/tvix/store/src/proto/tests/grpc_pathinfoservice.rs index e8da7792cd..66c0f01476 100644 --- a/tvix/store/src/proto/tests/grpc_pathinfoservice.rs +++ b/tvix/store/src/proto/tests/grpc_pathinfoservice.rs @@ -22,8 +22,8 @@ fn gen_grpc_service( let blob_service = gen_blob_service(); let directory_service = gen_directory_service(); Arc::new(GRPCPathInfoServiceWrapper::new(gen_pathinfo_service( - blob_service, - directory_service, + blob_service.into(), + directory_service.into(), ))) } diff --git a/tvix/store/src/tests/nar_renderer.rs b/tvix/store/src/tests/nar_renderer.rs index 811b572b6e..65059fe9c0 100644 --- a/tvix/store/src/tests/nar_renderer.rs +++ b/tvix/store/src/tests/nar_renderer.rs @@ -4,11 +4,16 @@ use crate::tests::fixtures::*; use crate::tests::utils::*; use sha2::{Digest, Sha256}; use std::io; +use std::sync::Arc; use tokio::io::sink; +use tvix_castore::blobservice::BlobService; +use tvix_castore::directoryservice::DirectoryService; use tvix_castore::proto as castorepb; #[tokio::test] async fn single_symlink() { + let blob_service: Arc = gen_blob_service().into(); + let directory_service: Arc = gen_directory_service().into(); let mut buf: Vec = vec![]; write_nar( @@ -18,8 +23,8 @@ async fn single_symlink() { target: "/nix/store/somewhereelse".into(), }), // don't put anything in the stores, as we don't actually do any requests. - gen_blob_service(), - gen_directory_service(), + blob_service, + directory_service, ) .await .expect("must succeed"); @@ -30,6 +35,9 @@ async fn single_symlink() { /// Make sure the NARRenderer fails if a referred blob doesn't exist. #[tokio::test] async fn single_file_missing_blob() { + let blob_service: Arc = gen_blob_service().into(); + let directory_service: Arc = gen_directory_service().into(); + let e = write_nar( sink(), &castorepb::node::Node::File(castorepb::FileNode { @@ -39,8 +47,8 @@ async fn single_file_missing_blob() { executable: false, }), // the blobservice is empty intentionally, to provoke the error. - gen_blob_service(), - gen_directory_service(), + blob_service, + directory_service, ) .await .expect_err("must fail"); @@ -57,7 +65,7 @@ async fn single_file_missing_blob() { /// than specified in the proto node. #[tokio::test] async fn single_file_wrong_blob_size() { - let blob_service = gen_blob_service(); + let blob_service: Arc = gen_blob_service().into(); // insert blob into the store let mut writer = blob_service.open_write().await; @@ -75,6 +83,7 @@ async fn single_file_wrong_blob_size() { let bs = blob_service.clone(); // Test with a root FileNode of a too big size { + let directory_service: Arc = gen_directory_service().into(); let e = write_nar( sink(), &castorepb::node::Node::File(castorepb::FileNode { @@ -84,7 +93,7 @@ async fn single_file_wrong_blob_size() { executable: false, }), bs, - gen_directory_service(), + directory_service, ) .await .expect_err("must fail"); @@ -100,6 +109,7 @@ async fn single_file_wrong_blob_size() { let bs = blob_service.clone(); // Test with a root FileNode of a too small size { + let directory_service: Arc = gen_directory_service().into(); let e = write_nar( sink(), &castorepb::node::Node::File(castorepb::FileNode { @@ -109,7 +119,7 @@ async fn single_file_wrong_blob_size() { executable: false, }), bs, - gen_directory_service(), + directory_service, ) .await .expect_err("must fail"); @@ -125,7 +135,8 @@ async fn single_file_wrong_blob_size() { #[tokio::test] async fn single_file() { - let blob_service = gen_blob_service(); + let blob_service: Arc = gen_blob_service().into(); + let directory_service: Arc = gen_directory_service().into(); // insert blob into the store let mut writer = blob_service.open_write().await; @@ -149,7 +160,7 @@ async fn single_file() { executable: false, }), blob_service, - gen_directory_service(), + directory_service, ) .await .expect("must succeed"); @@ -159,8 +170,8 @@ async fn single_file() { #[tokio::test] async fn test_complicated() { - let blob_service = gen_blob_service(); - let directory_service = gen_directory_service(); + let blob_service: Arc = gen_blob_service().into(); + let directory_service: Arc = gen_directory_service().into(); // put all data into the stores. // insert blob into the store -- cgit 1.4.1