From cfa4154131719db3ff687261bca95481cba609ab Mon Sep 17 00:00:00 2001 From: Bob van der Linden Date: Wed, 6 Nov 2024 23:13:33 +0100 Subject: feat(tvix): add instance_name to instrumentation of *Services Currently it is not possible to distinguish between tracing of the same *Service type whenever there are multiple of them. Now the instance_name of ServiceBuilder is passed into the *Service and used in the existing instrument as the `instance_name` field. Places that did not already have a instance_name in its context use `"default"`. In tests I used `"test"`. Change-Id: Ia20bf2a7bb849a781e370d087ba7ddb3be79f654 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12739 Tested-by: BuildkiteCI Autosubmit: Bob van der Linden Reviewed-by: flokli --- tvix/store/src/pathinfoservice/tests/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tvix/store/src/pathinfoservice/tests/mod.rs') diff --git a/tvix/store/src/pathinfoservice/tests/mod.rs b/tvix/store/src/pathinfoservice/tests/mod.rs index 12c685c80fad..f56e1015ea26 100644 --- a/tvix/store/src/pathinfoservice/tests/mod.rs +++ b/tvix/store/src/pathinfoservice/tests/mod.rs @@ -26,7 +26,7 @@ use self::utils::make_bigtable_path_info_service; let (_, _, svc) = make_grpc_path_info_service_client().await; svc })] -#[case::redb(RedbPathInfoService::new_temporary().unwrap())] +#[case::redb(RedbPathInfoService::new_temporary("test".into()).unwrap())] #[case::signing(test_signing_service())] #[cfg_attr(all(feature = "cloud",feature="integration"), case::bigtable(make_bigtable_path_info_service().await))] pub fn path_info_services(#[case] svc: impl PathInfoService) {} -- cgit 1.4.1