From 31d73cd443311c5ef4bfbd8c2b66e3b9691340ec Mon Sep 17 00:00:00 2001 From: edef Date: Wed, 8 May 2024 07:13:39 +0000 Subject: refactor(nix-compat/nar/reader): reuse prev_name allocation We reuse the prev_name allocation for Entry, instead of allocating and returning a separate Vec. We encode the `prev_name: None` case as an empty vector, since we don't allow empty names anyway, and the sorting is equivalent. Change-Id: I975b37ff873805f5ff099bc82128706891052247 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11607 Reviewed-by: Brian Olsen Reviewed-by: flokli Tested-by: BuildkiteCI --- tvix/store/src/nar/import.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tvix/store/src/nar/import.rs') diff --git a/tvix/store/src/nar/import.rs b/tvix/store/src/nar/import.rs index 7a9f1231e76a..3d7c50014aa8 100644 --- a/tvix/store/src/nar/import.rs +++ b/tvix/store/src/nar/import.rs @@ -87,7 +87,7 @@ where let mut path = path.clone(); // valid NAR names are valid castore names - path.try_push(&entry.name) + path.try_push(entry.name) .expect("Tvix bug: failed to join name"); let entry = Box::pin(produce_nar_inner( -- cgit 1.4.1