From 9cd2e920653914d4ef7bec525614d101f3fdd207 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Tue, 7 Nov 2023 21:54:47 +0200 Subject: refactor(tvix/store/fs): mv sparse -> populated directories Do this upgrade whenever someone is actually interested in the children of a directory, but that directory doesn't contain a more detailed listing. This is much more predictable, and removes a bunch of confusing code from the inode tracker itself. Change-Id: Ib3a13694d6d5d22887d2d04ae429592137f39cb4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/9982 Autosubmit: flokli Tested-by: BuildkiteCI Reviewed-by: Connor Brewster --- tvix/store/src/fs/inodes.rs | 13 ------------- 1 file changed, 13 deletions(-) (limited to 'tvix/store/src/fs/inodes.rs') diff --git a/tvix/store/src/fs/inodes.rs b/tvix/store/src/fs/inodes.rs index ed75a1bc7832..4047199982b2 100644 --- a/tvix/store/src/fs/inodes.rs +++ b/tvix/store/src/fs/inodes.rs @@ -55,16 +55,3 @@ impl From<&castorepb::DirectoryNode> for InodeData { )) } } - -/// converts a proto::Directory to a InodeData::Directory(DirectoryInodeData::Populated(..)). -/// The inodes for each child are 0, because it's up to the InodeTracker to allocate them. -impl From for InodeData { - fn from(value: castorepb::Directory) -> Self { - let digest = value.digest(); - - let children: Vec<(u64, castorepb::node::Node)> = - value.nodes().map(|node| (0, node)).collect(); - - InodeData::Directory(DirectoryInodeData::Populated(digest, children)) - } -} -- cgit 1.4.1