From d74c68025b5d1ffea3cd4f9731ee53b6ca2c6271 Mon Sep 17 00:00:00 2001 From: aspen Date: Tue, 20 Feb 2024 16:04:33 +0000 Subject: revert(tvix): don't use Rc::clone explicitly This reverts commit d9565a4d0af3bffd735a77aa6f1fd0ec0e03b14a. Reason for revert: this was intentional - putting Rc::clone instead of .clone is a common Rust idiom, and makes it explicit that we're cloning a shared reference, not an underlying resource Change-Id: I41a5f323ee35d7025dc7bb02f7d5d05d0051798d Reviewed-on: https://cl.tvl.fyi/c/depot/+/10995 Tested-by: BuildkiteCI Reviewed-by: flokli --- tvix/glue/benches/eval.rs | 4 ++-- tvix/glue/src/builtins/import.rs | 2 +- tvix/glue/src/builtins/mod.rs | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) (limited to 'tvix/glue') diff --git a/tvix/glue/benches/eval.rs b/tvix/glue/benches/eval.rs index 3e3dc533265f..dfb4fabe444a 100644 --- a/tvix/glue/benches/eval.rs +++ b/tvix/glue/benches/eval.rs @@ -46,8 +46,8 @@ fn interpret(code: &str) { ); eval.builtins.extend(impure_builtins()); - add_derivation_builtins(&mut eval, tvix_store_io.clone()); - add_fetcher_builtins(&mut eval, tvix_store_io.clone()); + add_derivation_builtins(&mut eval, Rc::clone(&tvix_store_io)); + add_fetcher_builtins(&mut eval, Rc::clone(&tvix_store_io)); add_import_builtins(&mut eval, tvix_store_io); configure_nix_path( &mut eval, diff --git a/tvix/glue/src/builtins/import.rs b/tvix/glue/src/builtins/import.rs index 536585102d45..7e21942e9196 100644 --- a/tvix/glue/src/builtins/import.rs +++ b/tvix/glue/src/builtins/import.rs @@ -129,7 +129,7 @@ mod import_builtins { path: Value, ) -> Result { let p = path.to_path()?; - let root_node = filtered_ingest(state.clone(), co, &p, Some(&filter)).await?; + let root_node = filtered_ingest(Rc::clone(&state), co, &p, Some(&filter)).await?; let name = tvix_store::import::path_to_name(&p)?; Ok(state diff --git a/tvix/glue/src/builtins/mod.rs b/tvix/glue/src/builtins/mod.rs index 78e5fe87ec4c..a62ba192871f 100644 --- a/tvix/glue/src/builtins/mod.rs +++ b/tvix/glue/src/builtins/mod.rs @@ -20,7 +20,7 @@ pub use derivation_error::Error as DerivationError; /// `known_paths`. pub fn add_derivation_builtins(eval: &mut tvix_eval::Evaluation, io: Rc) { eval.builtins - .extend(derivation::derivation_builtins::builtins(io)); + .extend(derivation::derivation_builtins::builtins(Rc::clone(&io))); // Add the actual `builtins.derivation` from compiled Nix code eval.src_builtins @@ -34,7 +34,7 @@ pub fn add_derivation_builtins(eval: &mut tvix_eval::Evaluation, io: Rc< /// * `fetchGit` pub fn add_fetcher_builtins(eval: &mut tvix_eval::Evaluation, io: Rc) { eval.builtins - .extend(fetchers::fetcher_builtins::builtins(io)); + .extend(fetchers::fetcher_builtins::builtins(Rc::clone(&io))); } /// Adds import-related builtins to the passed [tvix_eval::Evaluation]. @@ -82,8 +82,8 @@ mod tests { let mut eval = tvix_eval::Evaluation::new(io.clone() as Rc, false); - add_derivation_builtins(&mut eval, io.clone()); - add_fetcher_builtins(&mut eval, io.clone()); + add_derivation_builtins(&mut eval, Rc::clone(&io)); + add_fetcher_builtins(&mut eval, Rc::clone(&io)); add_import_builtins(&mut eval, io); // run the evaluation itself. -- cgit 1.4.1