From 7f29cab1cc9b0cc751b49d1dac7694f5841725ab Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Thu, 13 Jun 2024 10:40:48 +0300 Subject: fix(tvix/glue/tvix_store_io): distinguish waiting and building We immediately reported "Building", even though then populated necessary inputs, which looked a bit odd. Make it clear we're still waiting, and update the spinner message once we have all inputs we were waiting for. In the future, we might want to have separate spans for this, so the timer gets reset, but that's something for later. Change-Id: Ic22c9a906d0e7e7179c5ee328162401261efc224 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11799 Reviewed-by: aspen Tested-by: BuildkiteCI Autosubmit: flokli --- tvix/glue/src/tvix_store_io.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'tvix/glue') diff --git a/tvix/glue/src/tvix_store_io.rs b/tvix/glue/src/tvix_store_io.rs index ad9e4a8ef897..dd93b2be1b67 100644 --- a/tvix/glue/src/tvix_store_io.rs +++ b/tvix/glue/src/tvix_store_io.rs @@ -182,7 +182,7 @@ impl TvixStoreIO { let span = Span::current(); span.pb_start(); span.pb_set_style(&tvix_tracing::PB_SPINNER_STYLE); - span.pb_set_message(&format!("🔨Building {}", &store_path)); + span.pb_set_message(&format!("⏳Waiting for inputs {}", &store_path)); // derivation_to_build_request needs castore nodes for all inputs. // Provide them, which means, here is where we recursively build @@ -242,6 +242,8 @@ impl TvixStoreIO { .try_collect() .await?; + span.pb_set_message(&format!("🔨Building {}", &store_path)); + // TODO: check if input sources are sufficiently dealth with, // I think yes, they must be imported into the store by other // operations, so dealt with in the Some(…) match arm -- cgit 1.4.1