From 6b136dfd23c03cc61d189ad5d41dd881e45b677e Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sat, 30 Dec 2023 03:01:59 +0100 Subject: feat(tvix/glue): emit a warning in case of bad SRI hashes And include a test to ensure we show the warning. Change-Id: Ib6a436dbba2592b398b54e44f15a48d1aa345099 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10470 Tested-by: BuildkiteCI Reviewed-by: raitobezarius --- tvix/eval/src/warnings.rs | 3 +++ 1 file changed, 3 insertions(+) (limited to 'tvix/eval/src/warnings.rs') diff --git a/tvix/eval/src/warnings.rs b/tvix/eval/src/warnings.rs index e007d9c34f2d..f537aa913e40 100644 --- a/tvix/eval/src/warnings.rs +++ b/tvix/eval/src/warnings.rs @@ -18,6 +18,7 @@ pub enum WarningKind { EmptyInherit, EmptyLet, ShadowedOutput(String), + SRIHashWrongPadding, /// Tvix internal warning for features triggered by users that are /// not actually implemented yet, but do not cause runtime failures. @@ -105,6 +106,7 @@ impl EvalWarning { "this derivation's environment shadows the output name {}", out ), + WarningKind::SRIHashWrongPadding => "SRI hash has wrong padding".to_string(), WarningKind::NotImplemented(what) => { format!("feature not yet implemented in tvix: {}", what) @@ -127,6 +129,7 @@ impl EvalWarning { WarningKind::EmptyInherit => "W009", WarningKind::EmptyLet => "W010", WarningKind::ShadowedOutput(_) => "W011", + WarningKind::SRIHashWrongPadding => "W012", WarningKind::NotImplemented(_) => "W999", } -- cgit 1.4.1