From e15b6580cce173c7a3246d421c4d16285bd892e9 Mon Sep 17 00:00:00 2001 From: Ryan Lahfa Date: Tue, 26 Dec 2023 04:49:31 +0100 Subject: chore(tvix/eval): notes on coercion and contexts We make a case for adding a `reject_context` `CoercionKind` here. It does happen during concatenation actually for path concats. Change-Id: I0c196aad917550b9bcd0896cd2127a94f8181ffb Reviewed-on: https://cl.tvl.fyi/c/depot/+/10444 Tested-by: BuildkiteCI Reviewed-by: tazjin Autosubmit: raitobezarius --- tvix/eval/src/vm/mod.rs | 3 +++ 1 file changed, 3 insertions(+) (limited to 'tvix/eval/src/vm/mod.rs') diff --git a/tvix/eval/src/vm/mod.rs b/tvix/eval/src/vm/mod.rs index febf1cb195..e366121aba 100644 --- a/tvix/eval/src/vm/mod.rs +++ b/tvix/eval/src/vm/mod.rs @@ -1232,6 +1232,9 @@ async fn add_values(co: GenCo, a: Value, b: Value) -> Result { // contain any string context, the resulting error of such a // case can not be replicated by us. import_paths: false, + // FIXME(raitobezarius): per https://b.tvl.fyi/issues/364, this is a usecase + // for having a `reject_context: true` option here. This didn't occur yet in + // nixpkgs during my evaluations, therefore, I skipped it. }, ) .await -- cgit 1.4.1