From 3f2160627895e7d1fe3236812b83bddc5d3049f5 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Sat, 24 Sep 2022 15:54:21 +0300 Subject: refactor(tvix/eval): merge all bindings creation logic As of this commit, all three types of bindings scopes are compiled the same way (i.e. compilation of non-recursive attribute sets has been switched over to the new code paths). This sets us up for doing the final implementation of nested attribute sets. HOWEVER, this breaks the existing implementation of nested attributes in non-recursive attribute sets. That implementation is flawed and unworkable in practice, so we need to do this dance to be able to implement it correctly. Change-Id: Iba2545c0d1d6b51f5e1a31a5d005b8d01da546d3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6782 Reviewed-by: sterni Tested-by: BuildkiteCI --- .../tests/tvix_tests/disabled-eval-okay-contains-nested-non-set.nix | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tvix/eval/src/tests/tvix_tests/disabled-eval-okay-contains-nested-non-set.nix (limited to 'tvix/eval/src/tests/tvix_tests/disabled-eval-okay-contains-nested-non-set.nix') diff --git a/tvix/eval/src/tests/tvix_tests/disabled-eval-okay-contains-nested-non-set.nix b/tvix/eval/src/tests/tvix_tests/disabled-eval-okay-contains-nested-non-set.nix new file mode 100644 index 0000000000..361ba91445 --- /dev/null +++ b/tvix/eval/src/tests/tvix_tests/disabled-eval-okay-contains-nested-non-set.nix @@ -0,0 +1,3 @@ +# ? operator should work even if encountering a non-set value on the +# walk +{ a.b = 42; } ? a.b.c -- cgit 1.4.1