From 5095e4f2696ef85ee7c6ae0515eb8d1586459f8c Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Sun, 12 Mar 2023 21:49:29 +0300 Subject: feat(tvix/eval): add generator "name" to NativeError kind This produces traces in which we can see what kind of native code was run. Note that these "names" are named after the generator message, so these aren't *really* intended for end-user consumption, but we can give them saner names later. Example: https://gist.github.com/tazjin/82b24e92ace8e821008954867ee05057 This already makes the traces a little easier to parse. Change-Id: Idcd601baf84f492211b732ea0f04b377112e10d0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8268 Reviewed-by: flokli Tested-by: BuildkiteCI Autosubmit: tazjin --- tvix/eval/src/compiler/mod.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'tvix/eval/src/compiler/mod.rs') diff --git a/tvix/eval/src/compiler/mod.rs b/tvix/eval/src/compiler/mod.rs index 9cbbf62dbd0a..51dc49242882 100644 --- a/tvix/eval/src/compiler/mod.rs +++ b/tvix/eval/src/compiler/mod.rs @@ -1340,7 +1340,10 @@ fn compile_src_builtin( weak.upgrade().unwrap(), &mut crate::observer::NoOpObserver {}, ) - .map_err(|e| ErrorKind::NativeError(Box::new(e)))?; + .map_err(|e| ErrorKind::NativeError { + gen_type: "derivation", + err: Box::new(e), + })?; if !result.errors.is_empty() { return Err(ErrorKind::ImportCompilerError { -- cgit 1.4.1