From 5d9bfd7735373cde72ebac4be4a05f1c846c13ba Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Mon, 6 Mar 2023 17:23:17 +0300 Subject: fix(tvix/eval): emit warnings from builtins.import again Wires up generator logic to emit warnings that already have spans attached again. Change-Id: I9f878cec3b9d4f6f7819e7c71bab7ae70bd3f08b Reviewed-on: https://cl.tvl.fyi/c/depot/+/8224 Tested-by: BuildkiteCI Reviewed-by: raitobezarius --- tvix/eval/src/compiler/import.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'tvix/eval/src/compiler/import.rs') diff --git a/tvix/eval/src/compiler/import.rs b/tvix/eval/src/compiler/import.rs index 467fc256af..7e1aabbf1f 100644 --- a/tvix/eval/src/compiler/import.rs +++ b/tvix/eval/src/compiler/import.rs @@ -77,10 +77,9 @@ async fn import_impl( }); } - // TODO: emit not just the warning kind, hmm - // for warning in result.warnings { - // vm.push_warning(warning); - // } + for warning in result.warnings { + generators::emit_warning(&co, warning).await; + } // Compilation succeeded, we can construct a thunk from whatever it spat // out and return that. -- cgit 1.4.1