From 7d55b776de29cfaa70a2ab9ae61b6cabe70ed637 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Wed, 10 Aug 2022 21:09:59 +0300 Subject: feat(tvix): implement not-equals (!=) operator Change-Id: Ic259d6d0cf30553e944682a0d1d2c610df7fe5c2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6141 Reviewed-by: sterni Tested-by: BuildkiteCI --- tvix/eval/src/compiler.rs | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) (limited to 'tvix/eval/src/compiler.rs') diff --git a/tvix/eval/src/compiler.rs b/tvix/eval/src/compiler.rs index 4aadfaba80e7..d48490dde7a6 100644 --- a/tvix/eval/src/compiler.rs +++ b/tvix/eval/src/compiler.rs @@ -130,17 +130,22 @@ impl Compiler { use rnix::types::BinOpKind; - let opcode = match op.operator().unwrap() { - BinOpKind::Add => OpCode::OpAdd, - BinOpKind::Sub => OpCode::OpSub, - BinOpKind::Mul => OpCode::OpMul, - BinOpKind::Div => OpCode::OpDiv, - BinOpKind::Equal => OpCode::OpEqual, - BinOpKind::Update => OpCode::OpAttrsUpdate, + match op.operator().unwrap() { + BinOpKind::Add => self.chunk.add_op(OpCode::OpAdd), + BinOpKind::Sub => self.chunk.add_op(OpCode::OpSub), + BinOpKind::Mul => self.chunk.add_op(OpCode::OpMul), + BinOpKind::Div => self.chunk.add_op(OpCode::OpDiv), + BinOpKind::Update => self.chunk.add_op(OpCode::OpAttrsUpdate), + BinOpKind::Equal => self.chunk.add_op(OpCode::OpEqual), + + BinOpKind::NotEqual => { + self.chunk.add_op(OpCode::OpEqual); + self.chunk.add_op(OpCode::OpInvert) + } + _ => todo!(), }; - self.chunk.add_op(opcode); Ok(()) } -- cgit 1.4.1