From a3dbb60213fad39f73f6a03fb5e14eaa09b85670 Mon Sep 17 00:00:00 2001 From: Linus Heckemann Date: Thu, 24 Aug 2023 02:14:21 +0200 Subject: fix(tvix/eval): off-by-one in replaceStrings replaceStrings would previously fail to replace the last character in a string. Change-Id: I43a7c960945350b2e7a5b731b7fdb617723eb38f Reviewed-on: https://cl.tvl.fyi/c/depot/+/9151 Tested-by: BuildkiteCI Reviewed-by: sterni --- tvix/eval/src/builtins/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tvix/eval/src/builtins/mod.rs') diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs index d0c5bf5568b9..d701fa08a08d 100644 --- a/tvix/eval/src/builtins/mod.rs +++ b/tvix/eval/src/builtins/mod.rs @@ -723,7 +723,7 @@ mod pure_builtins { let from = elem.0.to_str()?; let to = elem.1.to_str()?; - if i + from.len() >= string.len() { + if i + from.len() > string.len() { continue; } -- cgit 1.4.1